⬆️ [#49] update dependencies #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-maertens
requested changes
Mar 12, 2024
.storybook/preview.ts
Outdated
There was a problem hiding this comment.
https://github.com/open-formulieren/formio-builder/blob/main/.storybook/preview.ts also has some additional type annotations that can/should be used here
| @@ -17,15 +17,15 @@ | |||
| "scripts": { | |||
| "build:esm": "tsc -p tsconfig.prod.json && tsc-alias -p tsconfig.prod.json", | |||
| "build:cjs": "tsc -p tsconfig.prod.json --module commonjs --outDir dist/cjs && tsc-alias -p tsconfig.prod.json --outDir dist/cjs", | |||
| "build:storybook": "build-storybook --webpack-stats-json", | |||
There was a problem hiding this comment.
the --webpack-stats-json was used for some reason 🤔
| @@ -42,49 +42,49 @@ | |||
| "homepage": "https://github.com/open-formulieren/formio-renderer#readme", | |||
| "peerDependencies": { | |||
| "formiojs": "~4.13.0 || ~4.14.0", | |||
| "react": "^17.0.2" | |||
| "react": "^18.2.0" | |||
| }, | |||
| "devDependencies": { | |||
There was a problem hiding this comment.
feel free to make the dev tools setup the same as the formio builder. I'd rather see ESLint added to both repositories at the same time instead of this mixed set up now.
This repo was started from a very outdated boilerplate, while the formio-builder one was crafted by hand. You can be bold ;)
nikkiysendoorn1
force-pushed
the
feature/update-dependencies
branch
2 times, most recently
from
03ff5a8 to
a9ddcad
Compare
nikkiysendoorn1
force-pushed
the
feature/update-dependencies
branch
2 times, most recently
from
1d8e385 to
ada7ba5
Compare
nikkiysendoorn1
force-pushed
the
feature/update-dependencies
branch
from
6cab75e to
4d5c640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.